Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check all proto files if changed #5998

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 15, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix: Check all proto files if changed

Before, we will not rebuild if config.proto changed.

Changelog

  • Bug Fix

Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 15, 2022 at 7:20AM (UTC)

@Xuanwo Xuanwo requested a review from drmingdrmer June 15, 2022 07:20
@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jun 15, 2022
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 LOC reduced:D

@BohuTANG BohuTANG merged commit 4417ac3 into databendlabs:main Jun 15, 2022
@Xuanwo Xuanwo deleted the fix-proto-conv branch July 1, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants