Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(async-trait): use unboxed_simple to simple GAT #5999

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jun 15, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

use unboxed_simple to simple GAT

Changelog

  • Improvement

Related Issues

Fixes #4408

Related https://github.com/wvwwvwwv/async-trait/pull/1

@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 15, 2022 at 7:47AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@PsiACE PsiACE requested a review from zhang2014 June 15, 2022 07:47
@PsiACE PsiACE requested review from sundy-li and zhang2014 and removed request for zhang2014 June 15, 2022 07:47
@PsiACE PsiACE marked this pull request as draft June 15, 2022 07:50
@Xuanwo
Copy link
Member

Xuanwo commented Jun 15, 2022

Wow, seems cool!

@PsiACE PsiACE marked this pull request as ready for review June 15, 2022 08:21
@PsiACE PsiACE requested a review from BohuTANG June 15, 2022 13:27
Copy link
Member

@zhang2014 zhang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it : D

@BohuTANG BohuTANG merged commit ea5f9b5 into databendlabs:main Jun 15, 2022
@PsiACE PsiACE deleted the async-trait branch June 15, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async-trait: use #[static_future] instead of boxing a future
5 participants