Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: add table name for column in explain #6230

Merged
merged 2 commits into from
Jun 26, 2022

Conversation

xudong963
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Adding table name for column to make explain clearer

Changelog

  • Improvement

Related Issues

Fixes #issue

@vercel
Copy link

vercel bot commented Jun 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 26, 2022 at 6:05AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@leiysky
Copy link
Contributor

leiysky commented Jun 25, 2022

sqllogic test is failed. Seems we can temporarily remove the explain test case in logictest suites?

@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2022

This pull request has merge conflicts that must be resolved before it can be merged. @xudong963 please update it 🙏.

Try @mergify update or update manually.

@BohuTANG
Copy link
Member

select t.number from numbers(1) as t where exists (select * from numbers(1) where number = t.number and t.number < number)
----
Project: [number]
<<<<<<< alis_table
    Filter: [subquery_3]
        CrossApply
            Scan: default.system.numbers
            Project: [subquery]
                EvalScalar: [count(*) > 0]
                    Aggregate: group items: [], aggregate functions: [count(*)]
                        Filter: [numbers.number = t.number, t.number < numbers.number]
                            Scan: default.system.numbers
=======
    HashJoin: SEMI, build keys: [number], probe keys: [number], join filters: [number < number]
        Scan: default.system.numbers
        Scan: default.system.numbers
>>>>>>> main

@xudong963 xudong963 force-pushed the alis_table branch 4 times, most recently from c477cdc to f40e358 Compare June 26, 2022 05:28
@mergify mergify bot merged commit 73b197f into databendlabs:main Jun 26, 2022
@xudong963 xudong963 deleted the alis_table branch June 26, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants