Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): Move util to root of crate with split of input #6239

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 27, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Changes included in this PR:

  • util moved to root of the crate
  • split Input and related functions into new mod input
  • make util and input private mods and only export required functions.

Changelog

  • Improvement

Xuanwo added 2 commits June 27, 2022 09:37
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel
Copy link

vercel bot commented Jun 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 27, 2022 at 1:49AM (UTC)

@Xuanwo Xuanwo requested a review from andylokandy June 27, 2022 01:49
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

mergify bot added a commit that referenced this pull request Jun 28, 2022
@BohuTANG BohuTANG merged commit 8a1b4cc into databendlabs:main Jun 28, 2022
@Xuanwo Xuanwo deleted the refactor-ast branch June 28, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants