Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metasrv] refactor grpc client #6278

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

ariesdevil
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Remove unused token lock.
Always assign to current_endpoint even if make_channel return error.

Changelog

  • Improvement

Related Issues

Fixes #issue

@vercel
Copy link

vercel bot commented Jun 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 28, 2022 at 2:26PM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

update

✅ Branch has been successfully updated

@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

Weird, no tests triggered. I'm investigating.

@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

Weird, no tests triggered. I'm investigating.

Oh, I got it. The commit in the main branch is ignored.

@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

yamllint failed for

yamllint -f auto .
make: yamllint: No such file or directory
make: *** [Makefile:30: lint-yaml] Error 127

@everpcpc PTAL

Seems we are using the wrong image?

@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

Thanks for the quick fix from @everpcpc, let's try again.

@mergify update

@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

update

✅ Branch has been successfully updated

@ariesdevil
Copy link
Contributor Author

yamllint failed for

yamllint -f auto .
make: yamllint: No such file or directory
make: *** [Makefile:30: lint-yaml] Error 127

@everpcpc PTAL

Seems we are using the wrong image?

Still failed

@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

Still failed

Image not updated, they work now!

image

@BohuTANG BohuTANG merged commit 06d8886 into databendlabs:main Jun 28, 2022
@ariesdevil ariesdevil deleted the refactor-grpc-client branch June 28, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants