[cla] setup the CLA assistant #714

PsiACE · 2021-06-03T18:29:43Z

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Signed-off-by: Chojan Shang psiace@outlook.com

Summary

Try to add the "CLA assistant".

add basic workflow
add docs, especially the DCLA.md ([docs] Add CLA #736 )
add token by owner, test & sign

Changelog

Other

Related Issues

Fixes #679

Test Plan

Add all files/tokens, try to sign the fist CLA.

How to setup or sign

WIP

Signed-off-by: Chojan Shang <psiace@outlook.com>

databend-bot · 2021-06-03T18:29:46Z

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

codecov-commenter · 2021-06-03T18:47:44Z

Codecov Report

Merging #714 (b834831) into master (73dd6e7) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #714    +/-   ##
=======================================
  Coverage      78%     78%            
=======================================
  Files         313     314     +1     
  Lines       17053   17215   +162     
=======================================
+ Hits        13308   13481   +173     
+ Misses       3745    3734    -11

Impacted Files	Coverage Δ
common/runtime/src/runtime_test.rs	`53% <0%> (-21%)`	⬇️
common/planners/src/plan_statistics.rs	`42% <0%> (-12%)`	⬇️
common/functions/src/udfs/database.rs	`70% <0%> (-4%)`	⬇️
common/functions/src/udfs/udf_example.rs	`91% <0%> (-2%)`	⬇️
common/functions/src/udfs/to_type_name.rs	`91% <0%> (-1%)`	⬇️
fusestore/store/src/meta_service/raftmeta.rs	`65% <0%> (-1%)`	⬇️
common/functions/src/hashes/hash.rs	`83% <0%> (ø)`
common/functions/src/function_alias.rs	`0% <0%> (ø)`
common/functions/src/function_literal.rs	`0% <0%> (ø)`
common/functions/src/strings/substring.rs	`66% <0%> (ø)`
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73dd6e7...b834831. Read the comment docs.

BohuTANG · 2021-06-04T01:07:31Z

.github/workflows/cla.yml

+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          # the below token should have repo scope and must be manually added by you in the repository's secret
+          PERSONAL_ACCESS_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}


What is this PERSONAL_ACCESS_TOKEN for?

What is this PERSONAL_ACCESS_TOKEN for?

See https://github.com/cla-assistant/github-action#6-adding-personal-access-token-as-a-secret

BohuTANG · 2021-06-04T01:09:11Z

.github/workflows/cla.yml

+        with:
+          # You do not need to create this file manually.
+          path-to-signatures: 'cla/signatures/version-1/cla.json'
+          path-to-document: 'https://github.com/datafuselabs/datafuse/blob/master/cla/agreements/DCLA.md'


path to website/datafuse/docs/cla/agreements/DCLA.md?

path to website/datafuse/docs/cla/agreements/DCLA.md?

Why not put everything related to cla together? We can use soft links to provide a copy for docs.

BTW, Clickhouse approach is very simple:

https://github.com/ClickHouse/ClickHouse/blob/master/.github/PULL_REQUEST_TEMPLATE.md

His robot will check the PR contains:

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

By retaining this you are agreeing to their CLA and do not need to sign.

But the complex is to have status check, I think this patch is to do it.

For us, just add a comment like this

I have read the CLA Document and I hereby sign the CLA

For this PR, the expected behavior is just like here: NixOS/nix.dev#40

BohuTANG · 2021-06-05T07:34:46Z

@PsiACE

Hi, first thanks for the contribution!
fusebots has add the PR text including detection and it can now detect CLA:
https://github.com/datafuselabs/fusebots/commit/1e47bb1fb8fbada90d43497a4dcc21b420ad1c2d

Add CLA in datafuse pull request:
9b0bfe7#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35

Demo is here:
#691

Signed-off-by: Chojan Shang <psiace@outlook.com>

databend-bot · 2021-06-05T09:43:47Z

Hello @PsiACE, Your pull request state is not in Draft, please add Reviewers or Re-request review again.
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky

PsiACE · 2021-06-05T09:53:58Z

datafuselabs/fusebots@1e47bb1

awesome , but I’m not sure if it can take effect on workflow. I update github.event.comment.body, I hope it can work correctly.

If it fails, we can try another solution with regex: https://github.com/Andrew-Test-Org/Public-Test-Repo/blob/89837fb1176de780c5a574cc195392b398ff01c3/.github/workflows/CLA.yml

Add CLA in datafuse pull request:
9b0bfe7#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35

Thank you very much, I updated the relevant path.

Demo is here:
#691

This PR also needs to be tested, good luck.

BohuTANG · 2021-06-05T10:08:32Z

hmm, actually we do not need any CLA workflow anymore.
@datafuse-bot will watch the PR update and check the PR's body, then start a Description check, if there is no CLA text in the body, the check will show the error in the checks list.

PsiACE · 2021-06-05T10:17:47Z

hmm, actually we do not need any CLA workflow anymore.
@datafuse-bot will watch the PR update and check the PR's body, then start a Description check, if there is no CLA text in the body, the check will show the error in the checks list.

but @datafuse-bot does not record the signatures.

BohuTANG · 2021-06-05T10:39:06Z

hmm, actually we do not need any CLA workflow anymore.
@datafuse-bot will watch the PR update and check the PR's body, then start a Description check, if there is no CLA text in the body, the check will show the error in the checks list.

but @datafuse-bot does not record the signatures.

Yes, this is not an signed CLA, it likes ClickHouse 'note' CLA:
If the contributor PR keeping the CLA notes, by default they are agreeing to it.

PsiACE · 2021-06-05T13:41:57Z

Yes, this is not an signed CLA, it likes ClickHouse 'note' CLA:
If the contributor PR keeping the CLA notes, by default they are agreeing to it.

Okay, I will close this PR. It can be reopened at any time when needed.

databend-bot · 2021-06-05T13:41:59Z

Hello @PsiACE, Your pull request state is not in Draft, please add Reviewers or Re-request review again.
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky

[cla] add basic workflow

196e5e5

Signed-off-by: Chojan Shang <psiace@outlook.com>

databend-bot added the pr-other label Jun 3, 2021

BohuTANG reviewed Jun 4, 2021

View reviewed changes

databendlabs deleted a comment from CLAassistant Jun 4, 2021

[cla] update path and comment

b834831

Signed-off-by: Chojan Shang <psiace@outlook.com>

PsiACE marked this pull request as ready for review June 5, 2021 09:43

PsiACE closed this Jun 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cla] setup the CLA assistant #714

[cla] setup the CLA assistant #714

PsiACE commented Jun 3, 2021 •

edited

Loading

databend-bot commented Jun 3, 2021

codecov-commenter commented Jun 3, 2021 •

edited

Loading

BohuTANG Jun 4, 2021

PsiACE Jun 4, 2021

BohuTANG Jun 4, 2021

PsiACE Jun 4, 2021

BohuTANG Jun 4, 2021

BohuTANG Jun 4, 2021

BohuTANG Jun 4, 2021

PsiACE Jun 4, 2021

PsiACE Jun 4, 2021

BohuTANG commented Jun 5, 2021 •

edited

Loading

databend-bot commented Jun 5, 2021

PsiACE commented Jun 5, 2021 •

edited

Loading

BohuTANG commented Jun 5, 2021 •

edited

Loading

PsiACE commented Jun 5, 2021

BohuTANG commented Jun 5, 2021 •

edited

Loading

PsiACE commented Jun 5, 2021

databend-bot commented Jun 5, 2021

[cla] setup the CLA assistant #714

[cla] setup the CLA assistant #714

Conversation

PsiACE commented Jun 3, 2021 • edited Loading

Summary

Changelog

Related Issues

Test Plan

How to setup or sign

databend-bot commented Jun 3, 2021

codecov-commenter commented Jun 3, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BohuTANG commented Jun 5, 2021 • edited Loading

databend-bot commented Jun 5, 2021

PsiACE commented Jun 5, 2021 • edited Loading

BohuTANG commented Jun 5, 2021 • edited Loading

PsiACE commented Jun 5, 2021

BohuTANG commented Jun 5, 2021 • edited Loading

PsiACE commented Jun 5, 2021

databend-bot commented Jun 5, 2021

PsiACE commented Jun 3, 2021 •

edited

Loading

codecov-commenter commented Jun 3, 2021 •

edited

Loading

BohuTANG commented Jun 5, 2021 •

edited

Loading

PsiACE commented Jun 5, 2021 •

edited

Loading

BohuTANG commented Jun 5, 2021 •

edited

Loading

BohuTANG commented Jun 5, 2021 •

edited

Loading