Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common/exception] concat ErrorCodes with its cause in display_text, instead of using cause #719

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Jun 4, 2021

Summary

  • concat ErrorCodes with its cause in display_text, instead of using field cause
  • add chained error test.

Changelog

  • Improvement

Related Issues

Remove unpreferred usage of cause mentioned in #713

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer drmingdrmer changed the title [common/exception] chains ErrorCodes with its cause in display_text, instead of by using field cause [common/exception] concat ErrorCodes with its cause in display_text, instead of by using cause Jun 4, 2021
@drmingdrmer drmingdrmer changed the title [common/exception] concat ErrorCodes with its cause in display_text, instead of by using cause [common/exception] concat ErrorCodes with its cause in display_text, instead of using cause Jun 4, 2021
@drmingdrmer drmingdrmer marked this pull request as ready for review June 4, 2021 06:04
@databend-bot
Copy link
Member

Hello @drmingdrmer, Your pull request state is not in Draft, please add Reviewers or Re-request review again."FuseQuery: @BohuTANG @sundy-li @zhang2014FuseStore: @drmingdrmer @dantengsky"

Copy link
Member

@zhang2014 zhang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 beautiful code! LGTM

@BohuTANG BohuTANG requested a review from zhang2014 June 4, 2021 06:32
@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 90cf20d into databendlabs:master Jun 4, 2021
@drmingdrmer drmingdrmer deleted the chain-err-in-text branch June 4, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants