Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[store/meta] feature: generate unique auto-incr number #728

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

drmingdrmer
Copy link
Member

Summary

[store/meta] feature: generate unique auto-incr number
  • Add new storage sequences to Meta. Introduce a corresponding new
    command Cmd::IncrSeq, to generate mono-incr sequence numbers.
    This feature enables Store to generate a globally unique u64 number,
    for a unique block/partition name.

    test_meta_server_incr_seq shows how to use this feature.

  • Simplify meta test cases by letting the state-machine test and the
    meta service test share a common test case set.

  • Remove unused codes etc.

Changelog

  • New Feature

Related Issues

#271

- Add new storage `sequences` to Meta. Introduce a corresponding new
  command `Cmd::IncrSeq`, to generate mono-incr sequence numbers.
  This feature enables Store to generate a globally unique u64 number,
  for a unique block/partition name.

  `test_meta_server_incr_seq` shows how to use this feature.

- Simplify meta test cases by letting the state-machine test and the
  meta service test share a common test case set.

- Remove unused codes etc.
@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Jun 4, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer drmingdrmer marked this pull request as ready for review June 4, 2021 12:37
@databend-bot
Copy link
Member

Hello @drmingdrmer, Your pull request state is not in Draft, please add Reviewers or Re-request review again.
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky

@drmingdrmer drmingdrmer requested a review from dantengsky June 4, 2021 12:38
Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit d919229 into databendlabs:master Jun 4, 2021
@drmingdrmer drmingdrmer deleted the meta-seq branch June 4, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants