-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(planner): support independent right join #7634
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
b9227ed
to
a3a1c3c
Compare
@mergify update |
✅ Branch has been successfully updated |
c9805c5
to
87318af
Compare
It would be better to 'make lint' let clippy check locally before push to the github. 'src/query/service/src/pipelines/processors/transforms/hash_join/join_hash_table.rs:696:41 |
select * from (SELECT number AS a FROM numbers(10000000)) x left join (SELECT number AS a FROM numbers(100000000)) y on x.a = y.a order by x.a;
10000000 rows in set (24.56 sec)
Read 110000000 rows, 839.23 MiB in 24.558 sec., 4.48 million rows/sec., 34.17 MiB/sec. After join reorder, the above query can be converted into the following right join with ~2x performance improvement. select * from (SELECT number AS a FROM numbers(100000000)) x right join (SELECT number AS a FROM numbers(10000000)) y on x.a = y.a order by x.a;
10000000 rows in set (10.58 sec)
Read 110000000 rows, 839.23 MiB in 10.578 sec., 10.4 million rows/sec., 79.34 MiB/sec. |
@mergify update |
✅ Branch has been successfully updated |
b317fc3
to
39ec4a2
Compare
rust-lang/rust-clippy#8987 A confusing lint |
src/query/service/src/pipelines/processors/transforms/hash_join/join_hash_table.rs
Outdated
Show resolved
Hide resolved
39ec4a2
to
fe2444f
Compare
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Support right join (won't convert into left join)
Fixes #7599