Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[store] refactor: IFileSystem API uses ref to str instead of String #777

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

drmingdrmer
Copy link
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] refactor: IFileSystem API uses ref to str instead of String

Changelog

  • Improvement

Related Issues

#271

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer drmingdrmer requested a review from dantengsky June 8, 2021 15:13
@drmingdrmer drmingdrmer marked this pull request as ready for review June 8, 2021 15:13
@codecov-commenter
Copy link

Codecov Report

Merging #777 (71695ef) into master (bcb8221) will increase coverage by 0%.
The diff coverage is 96%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #777   +/-   ##
======================================
  Coverage      78%     78%           
======================================
  Files         316     316           
  Lines       17337   17337           
======================================
+ Hits        13536   13538    +2     
+ Misses       3801    3799    -2     
Impacted Files Coverage Δ
fusestore/store/src/executor/action_handler.rs 69% <50%> (ø)
fusestore/store/src/data_part/appender.rs 94% <100%> (ø)
fusestore/store/src/dfs/distributed_fs.rs 94% <100%> (ø)
fusestore/store/src/dfs/distributed_fs_test.rs 96% <100%> (ø)
fusestore/store/src/localfs/local_fs.rs 94% <100%> (ø)
fusestore/store/src/localfs/local_fs_test.rs 94% <100%> (ø)
common/runtime/src/runtime_test.rs 86% <0%> (+13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe6bd8...71695ef. Read the comment docs.

Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 8e7eb19 into databendlabs:master Jun 8, 2021
@drmingdrmer drmingdrmer deleted the ifs-str branch June 9, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants