Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): name scheme with port number #7775

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

ClSlaid
Copy link
Contributor

@ClSlaid ClSlaid commented Sep 21, 2022

Signed-off-by: ClSlaid cailue@bupt.edu.cn

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

log show the port is alwayse parsed as none for url like 'http://127.0.0.1:8888/hits_100k.tsv'

2022-09-20T03:50:25.125708Z ERROR databend_query::servers::mysql::writers::query_result_writer: OnQuery Error: Code: 4000, displayText = operation interrupted (object error: (op: stat, path: hits_100k.tsv, source: sending request:  Custom { kind: Interrupted, error: reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Ipv4(127.0.0.1)), port: None, path: "/hits_100k.tsv", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 61, kind: ConnectionRefused, message: "Connection refused" })) } })).

Originally posted by @youngsofun in #7613 (comment)

Fixes #7745

Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 0:54AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Sep 21, 2022
@ClSlaid ClSlaid requested a review from Xuanwo September 21, 2022 08:33
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Xuanwo Xuanwo requested a review from youngsofun September 21, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-standards url can't parsed correctly
3 participants