-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[function] SELECT VERSION() #782
Conversation
Signed-off-by: Chojan Shang <psiace@outlook.com>
Thanks for the contribution! Please review the labels and make any necessary changes. |
Basically finished, just need some tests and documentation. @BohuTANG Could you please review it? cc @drmingdrmer , I checked the output file, oops, vargen can't gen |
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
=======================================
- Coverage 78% 77% -1%
=======================================
Files 314 317 +3
Lines 17215 17362 +147
=======================================
+ Hits 13481 13537 +56
- Misses 3734 3825 +91
Continue to review full report at Codecov.
|
@@ -0,0 +1,53 @@ | |||
// Copyright 2020-2021 The Datafuse Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, but why we need the udfs function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, got it.
It's ok to me.
@PsiACE The |
I may need a value, but get nothing. |
Here we should use: |
Confirmed It's my fault. Working on it. |
Is it possible to register the feature simd to the version description? Currently, the arrow is not using simd feature, even we have
Or using
Query:
Profile flamegraph: Need to investigate that. |
yep, i guess we can detect this feature. and gen version with
now, this feature is not enabled by default, try |
Show SIMD feature in the version, we want it. |
Signed-off-by: Chojan Shang <psiace@outlook.com>
Now, we can get version info like:
Or simd version like:
thanks @drmingdrmer |
@PsiACE nice shot man! |
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
+------------+ | ||
| default | | ||
+------------+ | ||
+-------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@@ -152,6 +152,7 @@ nav: | |||
- SIPHASH: sqlstatement/hash-functions/siphash.md | |||
- Information Functions: | |||
- DATABASE: sqlstatement/information-functions/database.md | |||
- VERSION: sqlstatement/information-functions/version.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI Passed |
Signed-off-by: Chojan Shang psiace@outlook.com
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
try add version() function.
Changelog
Related Issues
Fixes #762
Test Plan
Unit Tests
Stateless Tests