Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(processor): try fix cannot kill optimize table #7959

Merged
merged 5 commits into from
Sep 29, 2022

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Sep 29, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix(processor): try fix cannot kill optimize table

Fixes #7956

# Conflicts:
#	src/query/service/src/pipelines/processors/transforms/hash_join/hash_join_state.rs
@vercel
Copy link

vercel bot commented Sep 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Sep 29, 2022 at 7:34AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Sep 29, 2022
@zhang2014
Copy link
Member Author

rerun flake stateful test failure and comment to #7856

@zhang2014 zhang2014 marked this pull request as ready for review September 29, 2022 08:26
@BohuTANG
Copy link
Member

BohuTANG commented Sep 29, 2022

A test:

Case1: if the compact deal with block, we can abort: -- can be aborted

mysql> optimize table t7861 compact;
^C^C -- query aborted
^C^C -- query aborted
^C^C -- query aborted
^C^C -- query aborted
^C^C -- query aborted
^C^C -- query aborted
ERROR 1152 (08S01): Code: 1043, displayText = Aborted query, because the server is shutting down or the query was killed.

Case2: drop table xx all; -- can not be aborted
It seems we can't deal with block, so this case can not abort.

@BohuTANG BohuTANG merged commit e1846e7 into databendlabs:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: optimize table hang
2 participants