Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config options for bloom filter cache #8358

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Oct 20, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

config options for bloom filter cache

  • new config options for bloom index cache
    /// Max number of cached bloom index meta objects
    #[clap(long, default_value = "3000")]
    pub table_cache_bloom_index_meta_count: u64,

    /// Max bytes of cached bloom index, default value is 1GB
    #[clap(long, default_value = "1073741824")]
    pub table_cache_bloom_index_data_bytes: u64,
  • remove unused config options
   /// Max number of cached table block meta
   pub table_cache_block_meta_count: u64,
   /// Table memory cache size (mb)
   pub table_memory_cache_mb_size: u64,
   /// Table disk cache folder root
   pub table_disk_cache_root: String,
   /// Table disk cache size (mb)
   pub table_disk_cache_mb_size: u64,

Fixes #8279

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Oct 20, 2022 at 3:08PM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Oct 20, 2022
@dantengsky dantengsky marked this pull request as ready for review October 20, 2022 11:50
@dantengsky dantengsky requested review from Xuanwo and BohuTANG October 20, 2022 11:50
@BohuTANG BohuTANG merged commit d9a2aac into databendlabs:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: make bloom filter index cache configurable
3 participants