Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: decouple meta readers from TableContext #8395

Merged
merged 5 commits into from
Oct 22, 2022
Merged

refactor: decouple meta readers from TableContext #8395

merged 5 commits into from
Oct 22, 2022

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Oct 21, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • pure refactors
    • decouple meta readers from TableContext
    • change method Table::table_statistics to sync fn
  • add cache metrics to bloom index reader

Fixes #issue

@vercel
Copy link

vercel bot commented Oct 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Oct 22, 2022 at 2:09AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Oct 21, 2022
@dantengsky dantengsky marked this pull request as ready for review October 21, 2022 16:00
@dantengsky dantengsky marked this pull request as draft October 22, 2022 00:44
@dantengsky dantengsky marked this pull request as ready for review October 22, 2022 03:05
@dantengsky
Copy link
Member Author

@BohuTANG PTAL

@BohuTANG BohuTANG merged commit a510a89 into databendlabs:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

@leiysky leiysky Awaiting requested review from leiysky

@zhyass zhyass Awaiting requested review from zhyass

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantengsky @BohuTANG