refactor(meta/management): non blocking join #8410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade openraft v0.7.4-alpha.2..v0.7.4-alpha.3: Change-membership does not return error when replication lags. If `blocking` is `true`, `Raft::change_membership(..., blocking)` will block until repliication to new nodes become upto date. But it won't return an error when proposing change-membership log. - Join a node to cluster in non-blocking mode: the leader does not wait replication to the new node to become up to date. In case there are a logs to sync. - `MetaNode::get_leader()` should have a max timeout. Otherwise it may block for ever. - Fix: databendlabs#8386
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
refactor(meta/management): non blocking join
Upgrade openraft v0.7.4-alpha.2..v0.7.4-alpha.3:
Change-membership does not return error when replication lags.
If
blockingistrue,Raft::change_membership(..., blocking)willblock until repliication to new nodes become upto date.
But it won't return an error when proposing change-membership log.
Join a node to cluster in non-blocking mode: the leader does not wait
replication to the new node to become up to date. In case there are a
logs to sync.
MetaNode::get_leader()should have a max timeout. Otherwise it mayblock for ever.
Fix: Joining should be non-blocking #8386
Changelog
Related Issues