Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add for_each in Column trait #8777

Merged
merged 1 commit into from
Nov 14, 2022
Merged

feat: add for_each in Column trait #8777

merged 1 commit into from
Nov 14, 2022

Conversation

lichuang
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

feat: add for_each in Column trait

Closes #8776

@vercel
Copy link

vercel bot commented Nov 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Nov 13, 2022 at 2:14PM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Nov 13, 2022
Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

BTW, we are going to make datavalues crate deprecated by the new expression. So it's not recommended to add some trivial functions into it.

@BohuTANG BohuTANG merged commit aa173cc into databendlabs:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add for_each in Column trait to visit each row value of Column
3 participants