Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): avoid io copy in read parquet data #9365

Merged
merged 8 commits into from
Dec 27, 2022
Prev Previous commit
Next Next commit
Merge branch 'main' into refactor/avoid_io_copy
# Conflicts:
#	src/query/storages/fuse/src/io/read/block_reader_parquet.rs
  • Loading branch information
zhang2014 committed Dec 27, 2022
commit 9a077eda4019165aea5ec3c6307f1d58b7e9338a
26 changes: 17 additions & 9 deletions src/query/storages/fuse/src/io/read/block_reader_parquet.rs
Original file line number Diff line number Diff line change
@@ -238,14 +238,26 @@ impl BlockReader {
DataBlock::from_chunk(&self.projected_schema, &chunk)
}

pub fn deserialize(&self, part: PartInfoPtr, chunks: Vec<(usize, Vec<u8>)>) -> Result<DataBlock> {
pub fn deserialize(
&self,
part: PartInfoPtr,
chunks: Vec<(usize, Vec<u8>)>,
) -> Result<DataBlock> {
let start = Instant::now();
let reads = chunks
.iter()
.map(|(index, chunk)| (*index, chunk.as_slice()))
.collect::<Vec<_>>();

let part = FusePartInfo::from_part(&part)?;
self.deserialize_columns(part.nums_rows, &part.compression, &part.columns_meta, reads)
let deserialized_res = self.deserialize_columns(
part.nums_rows,
&part.compression,
&part.columns_meta,
reads,
);
metrics_inc_remote_io_deserialize_milliseconds(start.elapsed().as_millis() as u64);
deserialized_res
}

pub async fn read_columns_data(
@@ -254,9 +266,7 @@ impl BlockReader {
raw_part: PartInfoPtr,
) -> Result<Vec<(usize, Vec<u8>)>> {
// Perf
{
metrics_inc_remote_io_read_parts(1);
}
metrics_inc_remote_io_read_parts(1);

let part = FusePartInfo::from_part(&raw_part)?;
let columns = self.projection.project_column_leaves(&self.column_leaves)?;
@@ -271,10 +281,8 @@ impl BlockReader {
));

// Perf
{
metrics_inc_remote_io_seeks(1);
metrics_inc_remote_io_read_bytes(column_meta.len);
}
metrics_inc_remote_io_seeks(1);
metrics_inc_remote_io_read_bytes(column_meta.len);
}

let object = self.operator.object(&part.location);
You are viewing a condensed version of this merge commit. You can view the full changes here.