Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fuse): better table-meta and parquet reader function #9434

Merged
merged 5 commits into from
Dec 30, 2022
Merged

refactor(fuse): better table-meta and parquet reader function #9434

merged 5 commits into from
Dec 30, 2022

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Dec 30, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

This PR only refactored, not logic changed.

  • table-meta/common.rs -> staticits.rs and compression.rs
  • make block_reader_parquet.rs function name more readable

Closes #issue

@vercel
Copy link

vercel bot commented Dec 30, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Dec 30, 2022 at 3:38PM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 30, 2022
@BohuTANG BohuTANG marked this pull request as ready for review December 30, 2022 14:00
@BohuTANG BohuTANG requested a review from dantengsky December 30, 2022 14:00
@BohuTANG BohuTANG marked this pull request as draft December 30, 2022 14:14
@BohuTANG BohuTANG force-pushed the dev-refactor-parquer-reader branch from d610639 to 57d3e50 Compare December 30, 2022 15:30
@BohuTANG BohuTANG marked this pull request as ready for review December 30, 2022 15:41
dantengsky
dantengsky approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit 510252b into databendlabs:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantengsky dantengsky dantengsky approved these changes

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BohuTANG @dantengsky