Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): support named params for table functions. #9630

Merged
merged 2 commits into from
Jan 18, 2023
Merged

feat(query): support named params for table functions. #9630

merged 2 commits into from
Jan 18, 2023

Conversation

RinChanNOWWW
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW commented Jan 16, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

- When calling read_parquet, cache FileMetaData.

  • Support named parameters for table functions. The syntax is like:
select * from tbl_func(
    param1, param2, 
    op1=>literal1, op2=literal2, op3=>literal3
);

@vercel
Copy link

vercel bot commented Jan 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Jan 18, 2023 at 7:38AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jan 16, 2023
@RinChanNOWWW RinChanNOWWW mentioned this pull request Jan 16, 2023
Closed
@RinChanNOWWW RinChanNOWWW changed the title feat(storage): add cache for file meta. feat(query): add options for table functions and add cache for reading parquet file meta. Jan 17, 2023
@BohuTANG
Copy link
Member

BohuTANG commented Jan 17, 2023 •
edited
Loading

@RinChanNOWWW
I suggest not adding the cache for parquet file meta in this PR, @dantengsky is working on the new cache, we can do it after the refactoring.

Or, using the new cache: https://github.com/datafuselabs/databend/tree/main/src/query/storages/common/cache/src

@RinChanNOWWW RinChanNOWWW requested a review from Xuanwo January 17, 2023 11:58
@RinChanNOWWW RinChanNOWWW force-pushed the cache-file-meta branch 2 times, most recently from 3ebd07d to 3f89e10 Compare January 17, 2023 12:07
@RinChanNOWWW RinChanNOWWW changed the title feat(query): add options for table functions and add cache for reading parquet file meta. feat(query): add options for table functions. Jan 17, 2023
@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review January 17, 2023 12:46
Xuanwo
Xuanwo reviewed Jan 17, 2023
View reviewed changes
src/query/ast/src/ast/expr.rs Outdated Show resolved Hide resolved
src/query/sql/src/planner/semantic/type_check.rs Outdated Show resolved Hide resolved
@RinChanNOWWW RinChanNOWWW force-pushed the cache-file-meta branch 2 times, most recently from cb2df1f to e0161b3 Compare January 18, 2023 05:45
@RinChanNOWWW RinChanNOWWW changed the title feat(query): add options for table functions. feat(query): support named params for table functions. Jan 18, 2023
@RinChanNOWWW
Support syntax for named table function arg.
e27cafa 
`select * from func(name=>arg);`
@BohuTANG BohuTANG requested a review from andylokandy January 18, 2023 07:19
@mergify mergify bot merged commit 5d2a3f5 into databendlabs:main Jan 18, 2023
@RinChanNOWWW RinChanNOWWW deleted the cache-file-meta branch January 18, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@andylokandy andylokandy andylokandy approved these changes

@leiysky leiysky Awaiting requested review from leiysky

@sundy-li sundy-li Awaiting requested review from sundy-li

@dantengsky dantengsky Awaiting requested review from dantengsky

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RinChanNOWWW @BohuTANG @Xuanwo @andylokandy