Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update statistic during query execution #9633

Merged
merged 8 commits into from
Jan 17, 2023
Merged

feat: update statistic during query execution #9633

merged 8 commits into from
Jan 17, 2023

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Jan 16, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. Update statistics for filter and join during query execution, this will further improve the accuracy of CBO
  2. fix right join bug
  3. process some flaky tests

Closes #9631

@xudong963 xudong963 marked this pull request as draft January 16, 2023 12:31
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jan 16, 2023
@vercel
Copy link

vercel bot commented Jan 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Jan 17, 2023 at 10:29AM (UTC)

@xudong963 xudong963 requested a review from leiysky January 17, 2023 04:39
@xudong963 xudong963 marked this pull request as ready for review January 17, 2023 04:39
@BohuTANG BohuTANG requested a review from leiysky January 17, 2023 05:50
@xudong963
Copy link
Member Author

Strange.., a tpch test occurs wrong answer

13_0009_q9:                                                             [ FAIL ] - result differs with:
--- /Users/xudong/owner/databend/tests/suites/0_stateless/13_tpch/13_0009_q9.result	2022-10-18 15:31:02.000000000 +0800
+++ /Users/xudong/owner/databend/tests/suites/0_stateless/13_tpch/13_0009_q9.stdout	2023-01-17 13:55:21.000000000 +0800
@@ -1,5 +1,5 @@
 ALGERIA	1998	2321785.368
 ALGERIA	1997	3685016.858
-ALGERIA	1996	4276597.425
+ALGERIA	1996	4269554.726
 ALGERIA	1995	4418370.415
-ALGERIA	1994	3864849.952
+ALGERIA	1994	3855080.378

@xudong963 xudong963 marked this pull request as draft January 17, 2023 05:58
@xudong963
Copy link
Member Author

Strange.., a tpch test occurs wrong answer

13_0009_q9:                                                             [ FAIL ] - result differs with:
--- /Users/xudong/owner/databend/tests/suites/0_stateless/13_tpch/13_0009_q9.result	2022-10-18 15:31:02.000000000 +0800
+++ /Users/xudong/owner/databend/tests/suites/0_stateless/13_tpch/13_0009_q9.stdout	2023-01-17 13:55:21.000000000 +0800
@@ -1,5 +1,5 @@
 ALGERIA	1998	2321785.368
 ALGERIA	1997	3685016.858
-ALGERIA	1996	4276597.425
+ALGERIA	1996	4269554.726
 ALGERIA	1995	4418370.415
-ALGERIA	1994	3864849.952
+ALGERIA	1994	3855080.378

Precision problem

@xudong963 xudong963 marked this pull request as ready for review January 17, 2023 10:29
@xudong963 xudong963 merged commit e80d713 into databendlabs:main Jan 17, 2023
@xudong963 xudong963 deleted the update_stats branch January 17, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiysky leiysky leiysky approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: update statistics during query execution
2 participants
@xudong963 @leiysky