Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Add total count to sqllogic test console output #9802

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

johnhaxx7
Copy link
Contributor

@johnhaxx7 johnhaxx7 commented Jan 31, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Verified by ad-hoc console tests.

./target/debug/databend-sqllogictests --run_file 05_0001_ddl_create_database --no-fail-fast
MySQL client starts to run with: SqlLogicTestArgs { dir: None, file: Some("05_0001_ddl_create_database"), skipped_dir: None, handlers: None, suites: "tests/sqllogictests/suites", complete: false, no_fail_fast: true, parallel: 1, enable_sandbox: false, debug: false }
Running MySQL test for file: tests/sqllogictests/suites/base/05_ddl/05_0001_ddl_create_database ...
Completed MySQL test for file: tests/sqllogictests/suites/base/05_ddl/05_0001_ddl_create_database ❌ (594.230131ms)

Test finished, fail fast disabled, 2 out of 20 records failed to run

0: statement is expected to fail with error:
	1234
but got error:
	mysql client error: Server error: `ERROR HY000 (1105): Code: 2301, displayText = Database 'db' already exists.'
[SQL] CREATE DATABASE db
at tests/sqllogictests/suites/base/05_ddl/05_0001_ddl_create_database:18

1: statement is expected to fail with error:
	23101
but got error:
	mysql client error: Server error: `ERROR HY000 (1105): Code: 2301, displayText = system database exists.'
[SQL] CREATE DATABASE system
at tests/sqllogictests/suites/base/05_ddl/05_0001_ddl_create_database:24

Error: SelfError("sqllogictest failed")

Run all tests[20] using 15418 ms
Closes #9717

@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 1, 2023 at 3:05AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2023

This pull request's title is not fulfill the requirements. @johnhaxx7 please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@johnhaxx7 johnhaxx7 changed the title improve(test): Add total count to sqllogic test console output chore(test): Add total count to sqllogic test console output Jan 31, 2023
@johnhaxx7
Copy link
Contributor Author

Hi @xudong963 , PTAL thanks!

@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 31, 2023
@johnhaxx7 johnhaxx7 requested a review from xudong963 February 1, 2023 03:08
@xudong963 xudong963 requested a review from BohuTANG February 1, 2023 03:54
@BohuTANG BohuTANG merged commit b2636b7 into databendlabs:main Feb 1, 2023
@BohuTANG
Copy link
Member

BohuTANG commented Feb 1, 2023

@johnhaxx7 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve: databend-sqllogictests should return tests passed numbers
3 participants