Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): Support view in system.columns #9853

Merged
merged 3 commits into from
Feb 3, 2023
Merged

feat(query): Support view in system.columns #9853

merged 3 commits into from
Feb 3, 2023

Conversation

johnhaxx7
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Ditto

Closes #6922

@vercel
Copy link

vercel bot commented Feb 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 3, 2023 at 3:24AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Feb 2, 2023
@johnhaxx7
Copy link
Contributor Author

@sundy-li PTAL, thanks!

@BohuTANG BohuTANG requested a review from TCeason February 2, 2023 07:14
TCeason
TCeason approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pr, LGTM. Please let the ci pass.

@BohuTANG
Copy link
Member

BohuTANG commented Feb 2, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

update

✅ Branch has been successfully updated

@johnhaxx7
Copy link
Contributor Author

Can someone please help me merge this? The failing pipeline Dev MacOS / build_x86_64_macos(optional) is a network issue and not related to this change. Or to show me how to re-run it would be super helpful as well. Thanks!

@TCeason TCeason merged commit bfe1621 into databendlabs:main Feb 3, 2023
@TCeason
Copy link
Collaborator

TCeason commented Feb 3, 2023

Can someone please help me merge this? The failing pipeline Dev MacOS / build_x86_64_macos(optional) is a network issue and not related to this change. Or to show me how to re-run it would be super helpful as well. Thanks!

Done

@johnhaxx7 johnhaxx7 deleted the jhe-view-columns branch February 3, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RinChanNOWWW RinChanNOWWW RinChanNOWWW left review comments

@TCeason TCeason TCeason approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Columns of views in system.columns table
4 participants
@johnhaxx7 @BohuTANG @TCeason @RinChanNOWWW