Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): simplify UserAPI and RoleAPI by introducing a method update_xx_with(id, f: FnOnce) #9921

Merged
merged 5 commits into from
Feb 7, 2023

Conversation

drmingdrmer
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

refactor(meta): simplify UserAPI and RoleAPI by introducing a method update_xx_with(id, f: FnOnce)

Remove obsolete seq number form Option<u64>, replace it with MatchSeq.

chore(meta): remove obsolete impl From for Operation

Changelog

Related Issues

@vercel
Copy link

vercel bot commented Feb 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 7, 2023 at 0:56AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 7, 2023
@drmingdrmer drmingdrmer marked this pull request as ready for review February 7, 2023 10:39
@drmingdrmer
Copy link
Member Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2023

update

☑️ Nothing to do

  • #commits-behind>0 [:pushpin: update requirement]
  • -closed [:pushpin: update requirement]

@drmingdrmer
Copy link
Member Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 7f9499f into databendlabs:main Feb 7, 2023
@drmingdrmer drmingdrmer deleted the 50-refactor branch February 7, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants