Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(decimal): add operation for decimal #9926

Merged
merged 17 commits into from
Feb 10, 2023
Merged

feat(decimal): add operation for decimal #9926

merged 17 commits into from
Feb 10, 2023

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Feb 8, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  1. Support arithmetic for decimal types
  2. Support new datatype in meta.
  3. Support casting from number/decimal to decimal.

Closes #issue

@vercel
Copy link

vercel bot commented Feb 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 10, 2023 at 11:17AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Feb 8, 2023
@sundy-li sundy-li mentioned this pull request Feb 10, 2023
Closed
17 tasks
@drmingdrmer
Copy link
Member

Change to protobuf based message requires a new version and a new test:
https://github.com/datafuselabs/databend/blob/9975a7d09a0c88de90ca3a1256624115e509b8cb/src/meta/proto-conv/src/util.rs#L85-L91

@sundy-li sundy-li marked this pull request as ready for review February 10, 2023 09:17
@BohuTANG BohuTANG merged commit 20e0871 into databendlabs:main Feb 10, 2023
@drmingdrmer
Copy link
Member

It still needs a test:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer left review comments

@youngsofun youngsofun youngsofun approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sundy-li @drmingdrmer @youngsofun @BohuTANG