Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(functions): fix nullable and or domain cal #9928

Merged
merged 5 commits into from
Feb 8, 2023
Merged

fix(functions): fix nullable and or domain cal #9928

merged 5 commits into from
Feb 8, 2023

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Feb 8, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #issue

@vercel
Copy link

vercel bot commented Feb 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 8, 2023 at 9:09AM (UTC)

@sundy-li sundy-li requested a review from andylokandy February 8, 2023 07:08
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Feb 8, 2023
@BohuTANG
Copy link
Member

BohuTANG commented Feb 8, 2023

Add a logic test for the explain?

@BohuTANG
Copy link
Member

BohuTANG commented Feb 8, 2023

unit test panicked:

failures:

---- scalars::boolean::test_boolean stdout ----
thread 'scalars::boolean::test_boolean' panicked at 'assertion failed: result.as_ref().sematically_eq(&optimized_result.unwrap().as_ref())', src/query/functions/tests/it/scalars/mod.rs:99:27
stack backtrace:

@mergify mergify bot merged commit a5ea9a1 into databendlabs:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylokandy andylokandy andylokandy approved these changes

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundy-li @BohuTANG @andylokandy