Fix: Error After change_membership: assertion failed: value > prev: #584
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error After change_membership: `assertion failed: value > prev`, when changing membership by converting a learner to a voter. Because the replication streams are re-spawned, thus progress reverts to zero. Then a reverted progress causes the panic.
…atabendlabs#584 Problem: Error After change_membership: `assertion failed: value > prev`, when changing membership by converting a learner to a voter. Because the replication streams are re-spawned, thus progress reverts to zero. Then a reverted progress causes the panic. Solution: When re-spawning replications, remember the previous progress. - Fix: databendlabs#584
drmingdrmer
force-pushed
the
50-fix-584
branch
from
a3ad635
to
c558376
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fix: Error After change_membership:
assertion failed: value > prev: #584Problem:
Error After change_membership:
assertion failed: value > prev,when changing membership by converting a learner to a voter.
Because the replication streams are re-spawned, thus progress reverts to
zero. Then a reverted progress causes the panic.
Solution:
When re-spawning replications, remember the previous progress.
assertion failed: value > prev#584This change is