Skip to content

Additional Scripts for Repository #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Additional Scripts for Repository #2

wants to merge 2 commits into from

Conversation

liang108
Copy link

@liang108 liang108 commented Oct 6, 2020

To whom it may concern,

I have added several scripts to "Export" and "Reliability"; these scripts were written for use by a clinical psychology research group. I was wondering if the owner of this repository would like to see our user-written scripts and possibly add them to this repository so others may view them.

Best,
Jeffrey Liang

@ars17psu
Copy link

ars17psu commented Oct 7, 2020 via email

Copy link

@sh0sh1n sh0sh1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! See suggestions in comments.

# Updated 4.24.20

require 'Datavyu_API.rb'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was probably a "begin" here given the formatting. Suggest adding begin..end block back or reducing indent of subsequent sections.


puts ("EYE CONTACT: \n")

main_col = getColumn("eye_contact")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camel_case version of functions preferred (e.g., get_column)

require 'Datavyu_API.rb'

begin
ec = getColumn("eye_contact")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camel_case preferred

@@ -0,0 +1,213 @@
# Updated 4.24.20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be useful to have a description of what this script does—even if it's specific to a particular video-coding scheme it helps with understanding how to adapt it for a different scheme.

@sh0sh1n
Copy link

sh0sh1n commented Apr 5, 2021

@TheoWolf anyone volunteering currently to maintain this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants