Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Databricks bundle deploy fails when python.exe/python3.exe path has a space on windows #1065

Closed
cpc-jomich opened this issue Dec 13, 2023 · 1 comment · Fixed by #1075
Closed
Assignees
Labels
Bug Something isn't working DABs DABs related issues

Comments

@cpc-jomich
Copy link

Describe the issue

Given that python is installed in a folder with a space (e.g. c:\program files\python311)
when databricks bundle deploy is executed
then execution fails with a file does not exist error
msg="running: C:\\Program Files\\Python311\\python.exe setup.py bdist_wheel" msg="Error: build failed scr_data_sap, error: C:\\Program Files\\Python311\\python.exe setup.py bdist_wheel: exec: \"C:\\\\Program\": file does not exist, output: "

If I create a link in a folder that is in the path prior to the python path without spaces and use the 8.3 "short" path then execution succeeds.
Hardlink created for python3.exe <<===>> c:\progra~1\python311\python.exe

Configuration

Windows 11 dev machine
Python 3.11 installed in c:\program files\python311 folder
a simple DABs project with any asset to deploy

Steps to reproduce the behavior

Please list the steps required to reproduce the issue, for example:

  1. Run databricks bundle deploy
  2. See error

Expected Behavior

I would expect execution to succeed even if python is installed in a folder with a space on windows.

Actual Behavior

msg="running: C:\Program Files\Python311\python.exe setup.py bdist_wheel"
msg="Error: build failed scr_data_sap, error: C:\Program Files\Python311\python.exe setup.py bdist_wheel: exec: "C:\\Program": file does not exist, output: "

OS and CLI version

Windows 11
Databricks CLI v0.210.3

Is this a regression?

Did this work in a previous version of the CLI? If so, which versions did you try? Unknown

Debug Logs

Output logs if you run the command with debug logs enabled. Example: databricks bundle deploy --log-level=debug. Redact if needed

@cpc-jomich cpc-jomich added the DABs DABs related issues label Dec 13, 2023
@cpc-jomich cpc-jomich changed the title Databricks bundle deploy fails when python.exe path has a space on windows Databricks bundle deploy fails when python.exe/python3.exe path has a space on windows Dec 13, 2023
@andrewnester andrewnester added the Bug Something isn't working label Dec 14, 2023
@andrewnester andrewnester self-assigned this Dec 14, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 21, 2023
…reter (#1075)

## Changes
Instead of handling command chaining ourselves, we execute passed
commands as-is by storing them, in temp file and passing to correct
interpreter (bash or cmd) based on OS.

Fixes #1065 

## Tests
Added unit tests
@pietern
Copy link
Contributor

pietern commented Dec 21, 2023

@cpc-jomich Thanks for posting the issue. Via the work in #1075, this should be addressed in the next CLI release. This will be version v0.212.0 and will be released in the second week of January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working DABs DABs related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants