New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve default template #1046

Merged

lennartkats-db merged 6 commits into databricks:main from lennartkats-db:tweak-template

Dec 11, 2023

Contributor

lennartkats-db commented Dec 7, 2023

Changes

Tweak strings, documentation in template
Extend requirements-dev.txt with setuptools/wheel for building whl files
Clarify what the "_job.yml" file is for for users who are only interested in DLT pipelines (answering a question that came up recently)

Tests

Existing tests exercise this template

lennartkats-db added 3 commits

November 23, 2023 14:11


          Tune the default template

587fab2


          Tweak hint

ff4f825


          Merge remote-tracking branch 'databricks/main' into tweak-template

15f0dc8

lennartkats-db marked this pull request as ready for review

December 7, 2023 20:53

lennartkats-db requested a review from PaulCornellDB

December 8, 2023 11:02

PaulCornellDB reviewed

View reviewed changes

libs/template/templates/default-python/databricks_template_schema.json Outdated Show resolved Hide resolved

PaulCornellDB reviewed

View reviewed changes

libs/template/templates/default-python/template/{{.project_name}}/databricks.yml.tmpl Outdated Show resolved Hide resolved

PaulCornellDB reviewed

View reviewed changes

libs/template/templates/default-python/template/{{.project_name}}/databricks.yml.tmpl Show resolved Hide resolved

PaulCornellDB reviewed

View reviewed changes

libs/template/templates/default-python/template/{{.project_name}}/databricks.yml.tmpl Show resolved Hide resolved

PaulCornellDB reviewed

View reviewed changes

libs/template/templates/default-python/template/{{.project_name}}/databricks.yml.tmpl Outdated Show resolved Hide resolved

PaulCornellDB reviewed

View reviewed changes

libs/template/templates/default-python/template/{{.project_name}}/requirements-dev.txt.tmpl Outdated Show resolved Hide resolved

PaulCornellDB reviewed

View reviewed changes

...templates/default-python/template/{{.project_name}}/resources/{{.project_name}}_job.yml.tmpl Outdated Show resolved Hide resolved

PaulCornellDB reviewed

View reviewed changes

...templates/default-python/template/{{.project_name}}/resources/{{.project_name}}_job.yml.tmpl Show resolved Hide resolved

PaulCornellDB approved these changes

View reviewed changes

Contributor

PaulCornellDB left a comment

Generally LGTM. See my comments and proposed edits throughout.

lennartkats-db force-pushed the tweak-template branch from 437e424 to 15f0dc8 Compare

December 11, 2023 09:34

lennartkats-db added 2 commits

December 11, 2023 10:34


          Tweak template

77a9ba2


          Process review feedback

86f4b4a

Contributor Author

lennartkats-db commented Dec 11, 2023

Thanks for the thorough feedback, @PaulCornellDB!

lennartkats-db requested review from pietern and shreyas-goenka

December 11, 2023 09:44

pietern approved these changes

View reviewed changes

pietern changed the title ~~Default template TLC~~ Improve default template

lennartkats-db enabled auto-merge

December 11, 2023 15:33

lennartkats-db removed the request for review from shreyas-goenka

December 11, 2023 19:07


          Merge branch 'main' into tweak-template

1ab0b77

lennartkats-db added this pull request to the merge queue

Merged via the queue into databricks:main with commit 8b9930a

lennartkats-db deleted the tweak-template branch

December 11, 2023 19:19

andrewnester added a commit that referenced this pull request


          Release v0.210.3

9aaa67a

Bundles:
 * Improve default template ([#1046](#1046)).
 * Fix passthrough of pipeline notifications ([#1058](#1058)).

Internal:
 * Stub out Python virtual environment installation for `labs` commands ([#1057](#1057)).
 * Upgrade Terraform schema version to v1.31.1 ([#1055](#1055)).

Dependency updates:
 * Bump github.com/hashicorp/hc-install from 0.6.1 to 0.6.2 ([#1054](#1054)).
 * Bump github.com/databricks/databricks-sdk-go from 0.26.1 to 0.26.2 ([#1053](#1053)).

andrewnester mentioned this pull request

Release v0.210.3 #1062

Merged

github-merge-queue bot pushed a commit that referenced this pull request


          Release v0.210.3 (#1062)

dc12b3f

Bundles:
* Improve default template
([#1046](#1046)).
* Fix passthrough of pipeline notifications
([#1058](#1058)).

Internal:
* Stub out Python virtual environment installation for `labs` commands
([#1057](#1057)).
* Upgrade Terraform schema version to v1.31.1
([#1055](#1055)).


Dependency updates:
* Bump github.com/hashicorp/hc-install from 0.6.1 to 0.6.2
([#1054](#1054)).
* Bump github.com/databricks/databricks-sdk-go from 0.26.1 to 0.26.2
([#1053](#1053)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet