Return application_id for service principal lookups
#1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
changed the title
pietern
changed the title
application_id for service principal lookups
pietern
approved these changes
Mar 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1245 +/- ##
==========================================
+ Coverage 52.52% 52.54% +0.02%
==========================================
Files 308 308
Lines 17589 17614 +25
==========================================
+ Hits 9238 9256 +18
- Misses 7657 7664 +7
Partials 694 694 ☔ View full report in Codecov by Sentry. |
pietern
added a commit
that referenced
this pull request
Mar 6, 2024
CLI: * The SDK update fixes `fs cp` calls timing out when copying large files. Bundles: * Fix summary command when internal Terraform config doesn't exist ([#1242](#1242)). * Configure cobra.NoArgs for bundle commands where applicable ([#1250](#1250)). * Fixed building Python artifacts on Windows with WSL ([#1249](#1249)). * Add `--validate-only` flag to run validate-only pipeline update ([#1251](#1251)). * Only transform wheel libraries when using trampoline ([#1248](#1248)). * Return `application_id` for service principal lookups ([#1245](#1245)). * Support relative paths in artifact files source section and always upload all artifact files ([#1247](#1247)). * Fix DBConnect support in VS Code ([#1253](#1253)). Internal: * Added test to verify scripts.Execute mutator works correctly ([#1237](#1237)). API Changes: * Added `databricks permission-migration` command group. * Updated nesting of the `databricks settings` and `databricks account settings commands` * Changed `databricks vector-search-endpoints delete-endpoint` command with new required argument order. * Changed `databricks vector-search-indexes create-index` command with new required argument order. * Changed `databricks vector-search-indexes delete-data-vector-index` command with new required argument order. * Changed `databricks vector-search-indexes upsert-data-vector-index` command with new required argument order. OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04) Dependency updates: * Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 ([#1252](#1252)). * Update Go SDK to v0.34.0 ([#1256](#1256)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
CLI: * The SDK update fixes `fs cp` calls timing out when copying large files. Bundles: * Fix summary command when internal Terraform config doesn't exist ([#1242](#1242)). * Configure cobra.NoArgs for bundle commands where applicable ([#1250](#1250)). * Fixed building Python artifacts on Windows with WSL ([#1249](#1249)). * Add `--validate-only` flag to run validate-only pipeline update ([#1251](#1251)). * Only transform wheel libraries when using trampoline ([#1248](#1248)). * Return `application_id` for service principal lookups ([#1245](#1245)). * Support relative paths in artifact files source section and always upload all artifact files ([#1247](#1247)). * Fix DBConnect support in VS Code ([#1253](#1253)). Internal: * Added test to verify scripts.Execute mutator works correctly ([#1237](#1237)). API Changes: * Added `databricks permission-migration` command group. * Updated nesting of the `databricks settings` and `databricks account settings commands` * Changed `databricks vector-search-endpoints delete-endpoint` command with new required argument order. * Changed `databricks vector-search-indexes create-index` command with new required argument order. * Changed `databricks vector-search-indexes delete-data-vector-index` command with new required argument order. * Changed `databricks vector-search-indexes upsert-data-vector-index` command with new required argument order. OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04) Dependency updates: * Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 ([#1252](#1252)). * Update Go SDK to v0.34.0 ([#1256](#1256)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Return ApplicationId for service principals lookups
Fixes #1234
Tests
Added (regression) tests