PythonMutator: propagate source locations #1783
Open
+442
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
reviewed
Sep 26, 2024
|
|
||
| currentNode.location = location | ||
| currentNode.exists = true | ||
| } |
There was a problem hiding this comment.
Nit: this can be a member function of the type.
There was a problem hiding this comment.
I looked into changing but it doesn't make it obviously better. putPythonLocation/findPythonLocation is not intended to be used outside of merging code, so if we could limit visibility, we would only export mergePythonLocations and parsePythonLocations
There was a problem hiding this comment.
Ack, let's leave it
kanterov
force-pushed
the
kanterov/python-locations
branch
from
def4744 to
43ce278
Compare
kanterov
force-pushed
the
kanterov/python-locations
branch
from
96a6cef to
d9bf157
Compare
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a mechanism to load Python source locations in the Python mutator. Previously, locations pointed to generated YAML. Now, they point to Python sources instead. Python process outputs "locations.json" containing locations of bundle paths, examples:
{"path": "resources.jobs.job_0", "file": "resources/job_0.py", "line": 3, "column": 5} {"path": "resources.jobs.job_0.tasks[0].task_key", "file": "resources/job_0.py", "line": 10, "column": 5} {"path": "resources.jobs.job_1", "file": "resources/job_1.py", "line": 5, "column": 7}Such locations form a tree, and we assign locations of the closest ancestor to each
dyn.Valuebased on its path. For example,resources.jobs.job_0.tasks[0].task_keyis located atjob_0.py:10:5andresources.jobs.job_0.tasks[0].email_notificationsis located atjob_0.py:3:5, because we use the location of the job as the most precise approximation.This feature is only enabled if
experimental/pythonis used.Note: for now, we don't update locations with relative paths, because it has a side effect in changing how these paths are resolved
Example
Tests
Unit tests and manually