Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout variable lookup into separate files and tests #1921

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Breakout variable lookup into separate files and tests #1921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1f8f859
WIP
pietern Nov 20, 2024
16cd2de
WIP
pietern Nov 20, 2024
7a99df5
No need for pointers to the lookup structs
pietern Nov 20, 2024
488a1fb
Finalize
pietern Nov 20, 2024
ed62d08
Remove from codegen
pietern Nov 20, 2024
354d765
Rename types and add tests
pietern Nov 20, 2024
e8e89b0
Move and comment
pietern Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .codegen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
},
"batch": {
".codegen/cmds-workspace.go.tmpl": "cmd/workspace/cmd.go",
".codegen/cmds-account.go.tmpl": "cmd/account/cmd.go",
".codegen/lookup.go.tmpl": "bundle/config/variable/lookup.go"
".codegen/cmds-account.go.tmpl": "cmd/account/cmd.go"
},
"toolchain": {
"required": ["go"],
Expand Down
134 changes: 0 additions & 134 deletions .codegen/lookup.go.tmpl
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
bundle/config/variable/lookup.go linguist-generated=true
cmd/account/access-control/access-control.go linguist-generated=true
cmd/account/billable-usage/billable-usage.go linguist-generated=true
cmd/account/budgets/budgets.go linguist-generated=true
Expand Down
Loading
Loading