Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let caller set BRICKS_UPSTREAM for user agent #196

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Feb 2, 2023

Example when called from vscode (and everything is hooked up):

> * User-Agent: bricks/0.0.21-devel databricks-sdk-go/0.2.0 go/1.19.4 os/darwin upstream/databricks-vscode

@pietern pietern requested review from fjakobs and nfx February 2, 2023 22:43
@pietern
Copy link
Contributor Author

pietern commented Feb 2, 2023

Note: the base of this PR is #195 to keep the diff relevant.

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this? > * User-Agent: bricks/0.0.21-devel databricks-sdk-go/0.2.0 go/1.19.4 os/darwin cmd/sync databricks-vscode/0.1.23

@pietern pietern changed the title Let caller set BRICKS_INVOKED_BY for user agent Let caller set BRICKS_UPSTREAM for user agent Feb 3, 2023
@pietern pietern requested review from fjakobs and nfx February 3, 2023 14:03
@pietern
Copy link
Contributor Author

pietern commented Feb 3, 2023

In the latest revision we use BRICKS_UPSTREAM and BRICKS_UPSTREAM_VERSION.

They show up as keys upstream/foo and upstream-version/0.0.1 in the user agent.

Copy link
Contributor

@fjakobs fjakobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the interface looks good.

Base automatically changed from useragent to main February 3, 2023 15:47
@pietern pietern merged commit 2e01473 into main Feb 3, 2023
@pietern pietern deleted the useragent-vscode branch February 3, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants