Move integration tests to integration package
#2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Dec 13, 2024
denik
reviewed
Dec 13, 2024
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Dec 13, 2024
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Dec 13, 2024
| @@ -0,0 +1,20 @@ | |||
| package internal | |||
There was a problem hiding this comment.
nit: I find "internal" not very descriptive. "helpers" or "utils" or "setuputil" would be better.
There was a problem hiding this comment.
I can move it to a package inside internal. We do need the internal nesting because it means it can only be imported by other packages inside integration. See https://go.dev/doc/go1.4#internalpackages
denik
approved these changes
Dec 13, 2024
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/12317614117 |
|
One additional test skip in the last commit. Merging without waiting for another integration test run. |
denik
reviewed
Jan 2, 2025
| // TestMain is the entrypoint executed by the test runner. | ||
| // See [internal.Main] for prerequisites for running integration tests. | ||
| func TestMain(m *testing.M) { | ||
| internal.Main(m) |
There was a problem hiding this comment.
@pietern we might want to re-think this - it turns out having TestMain disables go test's built-in caching, which could be useful in speeding up test runs both locally and on CI.
shreyas-goenka
added a commit
that referenced
this pull request
Jan 2, 2025
## Changes This PR adds back debugging functionality that was lost during migration to `internal.Main` as an entry point for integration tests. The PR that caused the regression: #2009. Specifically the addition of internal.Main as the entrypoint for all integration tests. ## Tests Manually, by trying to debug a test.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
## Changes - Remove TestMain from integration tests and related checks. - This fixes "go test" caching for integration tests. The test_main.go files were added in #2009 to make sure integration tests are not run as part of go test ./.... We recommend running make test to run tests, which includes the packages to test (and excludes integration). ## Tests To test that caching works I ran a test twice: ``` + CLOUD_ENV=aws + go test --timeout 3h -v -run TestDefaultPython/3.9 ./integration/bundle/ … PASS ok github.com/databricks/cli/integration/bundle (cached) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Objectives:
go test ./...TestAcctest name prefixThe tree structure generally mirrors the source code tree structure.
Requirements for new files in this directory:
_testappendedmain_test.gofile.These requirements are enforced by a unit test in the
integrationpackage.Tests
Integration tests pass.
The total run time regresses by about 10%. A follow-up change that increases the degree of test parallelism will address this.