Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate U2M Code to SDKs #2076

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[WIP] Migrate U2M Code to SDKs #2076

wants to merge 11 commits into from

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Jan 3, 2025

Changes

Ports the SDK to this change: databricks/databricks-sdk-go#1108. This eliminates the need for the SDK to invoke itself (!) when loading an OAuth token. It also allows us to respond with more suitable errors when fetching tokens.

One concrete improvement with this change is that the error message returned when a refresh token is invalid now provides the correct command to run, including the appropriate --profile flag.

Tests

Copy link

github-actions bot commented Jan 3, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 2076
  • Commit SHA: c6cbc42b4e4cc0855a3ed826a571d9f021027637

Checks will be approved automatically on success.

@mgyucht mgyucht temporarily deployed to test-trigger-is January 3, 2025 13:47 — with GitHub Actions Inactive
@denik denik mentioned this pull request Jan 6, 2025
@mgyucht mgyucht temporarily deployed to test-trigger-is January 7, 2025 17:01 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 7, 2025 17:04 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 7, 2025 17:08 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 8, 2025 11:02 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 8, 2025 11:11 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant