-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Migrate U2M Code to SDKs #2076
Open
mgyucht
wants to merge
11
commits into
main
Choose a base branch
from
move-u2m-to-sdks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyucht
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
January 3, 2025 13:47
mgyucht
temporarily deployed
to
test-trigger-is
January 3, 2025 13:47 — with
GitHub Actions
Inactive
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
mgyucht
temporarily deployed
to
test-trigger-is
January 3, 2025 13:47 — with
GitHub Actions
Inactive
Merged
mgyucht
temporarily deployed
to
test-trigger-is
January 7, 2025 17:01 — with
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
January 7, 2025 17:04 — with
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
January 7, 2025 17:08 — with
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
January 8, 2025 11:02 — with
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
January 8, 2025 11:11 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ports the SDK to this change: databricks/databricks-sdk-go#1108. This eliminates the need for the SDK to invoke itself (!) when loading an OAuth token. It also allows us to respond with more suitable errors when fetching tokens.
One concrete improvement with this change is that the error message returned when a refresh token is invalid now provides the correct command to run, including the appropriate
--profile
flag.Tests