Fix for regression deploying resources with PyPi and Maven library types #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
pietern,
shreyas-goenka and
denik
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Feb 12, 2025
andrewnester
added a commit
that referenced
this pull request
Feb 12, 2025
pietern
added a commit
that referenced
this pull request
Feb 12, 2025
## Changes These changes break the use of non-local libraries (such as PyPI libraries). This reverts the set so we can cut a patch release and take a closer look later. Original PRs are #2297 and #2341. Issue reported in #2343. ## Tests Manually confirmed that a bundle with PyPI package in libraries now deploys fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The CheckForSameNameLibraries mutator incorrectly assumed all resource libraries define libraries as paths of the
stringtype, but some libraries, such as PyPi and Maven, define them as objects.This PR addresses this issue. It was introduced in #2297.
Tests
Added regression test.