Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for bundle.Seq, simplified Mutator.Apply interface #403

Merged
merged 3 commits into from
May 24, 2023
Merged

Added support for bundle.Seq, simplified Mutator.Apply interface #403

merged 3 commits into from
May 24, 2023

Conversation

andrewnester
Copy link
Contributor

Changes

Added support for bundle.Seq, simplified Mutator.Apply interface by removing list of mutators from return values/

Tests

  1. Ran cli bundle deploy and interrupted it with Cmd + C mid execution so lock is not released
  2. Ran cli bundle deploy top make sure that CLI is not trying to release lock when it fail to acquire it
andrew.nester@HFW9Y94129 multiples-tasks % cli bundle deploy
Starting upload of bundle files
Uploaded bundle files at /Users/andrew.nester@databricks.com/.bundle/simple-task/development/files!

^C
andrew.nester@HFW9Y94129 multiples-tasks % cli bundle deploy
Error: deploy lock acquired by andrew.nester@databricks.com at 2023-05-24 12:10:23.050343 +0200 CEST. Use --force to override

pietern
pietern reviewed May 24, 2023
View reviewed changes
shreyas-goenka
shreyas-goenka approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@shreyas-goenka shreyas-goenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewnester andrewnester requested a review from pietern May 24, 2023 11:33
@andrewnester andrewnester merged commit 6141476 into main May 24, 2023
@andrewnester andrewnester deleted the bundle-seq branch May 24, 2023 12:45
@pietern pietern mentioned this pull request May 26, 2023
Merged
pietern added a commit that referenced this pull request May 26, 2023
@pietern
Release v0.100.2 (#410)
e366faf 
## Changes

CLI:
* Reduce parallellism in locker integration test
([#407](#407)).

Bundles:
* Don't pass synthesized TMPDIR if not already set
([#409](#409)).
* Added support for bundle.Seq, simplified Mutator.Apply interface
([#403](#403)).
* Regenerated internal schema structs based on Terraform provider
schemas ([#401](#401)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@shreyas-goenka shreyas-goenka shreyas-goenka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewnester @pietern @shreyas-goenka