Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insecure option to configure #118

Merged
merged 3 commits into from
May 30, 2018
Merged

Conversation

andrewmchen
Copy link
Contributor

@andrewmchen andrewmchen commented Apr 30, 2018

We would like to use the CLI against shards without proper SSL certificates. (For development purposes.)

@codecov-io
Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #118 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage    78.9%   79.04%   +0.13%     
==========================================
  Files          25       25              
  Lines        1370     1379       +9     
==========================================
+ Hits         1081     1090       +9     
  Misses        289      289
Impacted Files Coverage Δ
databricks_cli/configure/provider.py 100% <100%> (ø) ⬆️
databricks_cli/configure/config.py 96.77% <100%> (+0.1%) ⬆️
databricks_cli/configure/cli.py 92.68% <100%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9090000...94336c8. Read the comment docs.

@ericwang-db
Copy link
Contributor

@andrewmchen Nice! Why did you prefer to make this a config option vs a command line option that's per command invocation (like --profile). That seems to be more in line with CURL behavior, and makes the lack of trust more explicit.

@andrewmchen
Copy link
Contributor Author

IMO, that doesn't make a lot of sense. Whether or not the host has SSL set up correctly is super coupled to the profile so it should be configured with the profile I think.

@ericwang-db
Copy link
Contributor

@andrewmchen looks good! However, could we make insecure not show up in ~/.databrickscfg when it is set to None? That happens for username/password when switching the default config to token-based auth.

@ericwang-db
Copy link
Contributor

@andrewmchen made a change to make ^ happen. ericwang-db@81abbee

Could you cherry-pick and let's close this PR?

@ericwang-db
Copy link
Contributor

lgtm

@andrewmchen andrewmchen merged commit cb4b3be into databricks:master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants