Add feature to permanent delete cluster. #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmchen
force-pushed
the
permanent-delete
branch
from
a715cbc
to
8c10845
Compare
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 83.03% 83.07% +0.03%
==========================================
Files 31 31
Lines 1957 1967 +10
==========================================
+ Hits 1625 1634 +9
- Misses 332 333 +1
Continue to review full report at Codecov.
|
andrewmchen
force-pushed
the
permanent-delete
branch
from
8c10845
to
4ffd6f1
Compare
andrewmchen
force-pushed
the
permanent-delete
branch
from
4ffd6f1
to
e286444
Compare
smurching
reviewed
Feb 1, 2019
| @provide_api_client | ||
| def permanent_delete_cli(api_client, cluster_id): | ||
| """ | ||
| Permanently deletes a Spark cluster. |
There was a problem hiding this comment.
Nanonit: I know we copied this from the REST API docs - we could consider explicitly mentioning that this is irreversible (although I guess "permanent" already implies that). Also, maybe we should say "Databricks cluster" instead of "Spark cluster" to maintain parity with the other clusters commands, e.g:
"Permanently and irreversibly deletes a Databricks cluster"
smurching
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176.