Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2.1 API version for UC paths #498

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

adamcain-db
Copy link
Contributor

Replaces PR #496

  • Use 2.1 for API version with UC API paths (/unity-catalog and /lineage-tracking)
  • Simple test for the above.
  • Tested with various unity-catalog commands with --debug option.

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of the files under /examples/unity_catalog need to be updated as well?

@adamcain-db
Copy link
Contributor Author

adamcain-db commented Jun 22, 2022

Do any of the files under /examples/unity_catalog need to be updated as well?

Good point. We will soon want to change the permissions in update-permissions1.json and rename it to clarify which object it applies to. However, the UC service doesn't yet support those new permissions on input. So that will need to be in a follow-up change.

I went ahead and removed the replace-permissions1.json example file, since we (still) don't support that endpoint yet (though we know @nfx wants it, tracked in https://databricks.atlassian.net/browse/SC-103707).

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #498 (dc03819) into main (e6c10f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   61.10%   61.10%           
=======================================
  Files          55       55           
  Lines        4664     4664           
=======================================
  Hits         2850     2850           
  Misses       1814     1814           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c10f9...dc03819. Read the comment docs.

@adamcain-db adamcain-db requested a review from pietern June 23, 2022 13:54
@pietern pietern merged commit 0e4c869 into databricks:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants