Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SDK for Delta Pipelines to match API PipelineSettings definition #501

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

stawo
Copy link
Contributor

@stawo stawo commented Jun 22, 2022

In the Delta Live Tables API 2.0, the PipelineSettings definition (link) used in the create (link) and edit (link) methods specify the following elements which are not present in the SDK code: target, continuous, development.

There are instead two elements (trigger and filters) which are not used and, if specified when using the SDK functions, make the code fail.

Added `continuous` and `development` parameters.
Removed `trigger` and `filters` parameters.
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @stawo! Left a comment on the removal.

databricks_cli/sdk/service.py Outdated Show resolved Hide resolved
@stawo
Copy link
Contributor Author

stawo commented Jun 27, 2022

@pietern , implemented your suggestion.

@pietern
Copy link
Contributor

pietern commented Jun 28, 2022

Thanks for the update! It'll be released with the next patch release.

@pietern pietern merged commit 6ad6b41 into databricks:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants