Add 'metastores get-assignment' CLI for UC #527
Conversation
Codecov Report
@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 60.93% 60.73% -0.20%
==========================================
Files 55 55
Lines 4669 4684 +15
==========================================
Hits 2845 2845
- Misses 1824 1839 +15
Continue to review full report at Codecov.
|
| @@ -193,6 +206,8 @@ def register_metastore_commands(cmd_group): | |||
| cmd_group.add_command(hide(metastore_summary_cli), name='metastore-summary') | |||
| cmd_group.add_command(hide(assign_metastore_cli), name='assign-metastore') | |||
| cmd_group.add_command(hide(unassign_metastore_cli), name='unassign-metastore') | |||
| cmd_group.add_command(hide(get_metastore_assignment_cli), | |||
There was a problem hiding this comment.
Do we need this? Based on the comment, these are "deprecated" commands
There was a problem hiding this comment.
No, I just kinda liked the get-metastore-assignment version. Can remove it, if you prefer.
|
I'll wait for @pietern to have a chance to review before I merge this. |
There was a problem hiding this comment.
LGTM
@adamcain-db Can you add one or two UC tests to set a precedent? Can be done as separate PR. Would be good to ensure new functionality gets tested. For this one it would be good to have a mocked response payload and expectations on the output. It looks like the current approach just dumps the JSON returned by the server, but it might be more in line with expectations to only print the metastore ID.
|
@adamcain-db Please enable commit signing and repush so we can merge. |
adamcain-db
force-pushed
the
add-get-current-metastore-assignment
branch
from
620d175 to
663ad19
Compare
adamcain-db
force-pushed
the
add-get-current-metastore-assignment
branch
from
663ad19 to
042cb00
Compare
I think we should keep dumping the full JSON (as done with the other I'll add unit tests in a separate PR. |
|
Understood, thanks for clarifying. |
unity-catalog metastores get-assignment(a.k.a.unity-catalog get-metastore-assignment) for exercising new UCgetCurrentMetastoreAssignmentAPI endpoint