Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add-schema, update-schema, and remove-schema to Delta Sharing CLI #608

Merged
merged 8 commits into from
Apr 6, 2023

Conversation

andyl-db
Copy link
Contributor

@andyl-db andyl-db commented Mar 4, 2023

This PR adds the following command to Delta Sharing CLI:

databricks unity-catalog shares add-schema 
  --share a 
  --schema b
  --comment "comment to update to"

databricks unity-catalog shares add-schema
  --share a 
  --schema b
  --json "{...}"

databricks unity-catalog shares add-schema
  --share a 
  --schema b
  --json-file /path/to/json/file

databricks unity-catalog shares update-schema 
  --share a 
  --schema b
  --comment "comment to update to"
  
databricks unity-catalog shares update-schema
  --share a 
  --schema b
  --json "{...}"

databricks unity-catalog shares update-schema
  --share a 
  --schema b
  --json-file /path/to/json/file

databricks unity-catalog shares remove-schema
  --share a
  --schema b

@andyl-db andyl-db requested review from wchau and pietern March 4, 2023 07:02
@andyl-db andyl-db requested a review from wchau March 7, 2023 18:48
databricks_cli/unity_catalog/delta_sharing_cli.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 68.80% and project coverage change: -0.18 ⚠️

Comparison is base (fd2ad70) 75.81% compared to head (edbefe7) 75.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   75.81%   75.63%   -0.18%     
==========================================
  Files          55       55              
  Lines        4924     5016      +92     
==========================================
+ Hits         3733     3794      +61     
- Misses       1191     1222      +31     
Impacted Files Coverage Δ
databricks_cli/unity_catalog/delta_sharing_cli.py 81.58% <68.80%> (-4.17%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pietern pietern merged commit 5f6853a into databricks:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants