Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove imp dependency and test on python 3.12 #673

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Remove imp dependency and test on python 3.12 #673

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab3f029
Remove imp dependency and test on python 3.12
mgyucht Oct 4, 2023
ab00f06
Merge branch 'main' into remove-imp
mgyucht Oct 4, 2023
69801cf
inline version
mgyucht Oct 4, 2023
9cda830
one more tweak
mgyucht Oct 4, 2023
2f73832
do not lint on 3.12
mgyucht Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- '3.9'
- '3.10'
- '3.11'

- '3.12'
env:
PYTHON_VERSION: ${{ matrix.python-version }}
steps:
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
- '3.9'
- '3.10'
- '3.11'

- '3.12'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also run this on all versions we support to be sure.

env:
PYTHON_VERSION: ${{ matrix.python-version }}
steps:
Expand Down
7 changes: 4 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import imp
import io
import os
from setuptools import setup, find_packages
from importlib.machinery import SourceFileLoader

version = imp.load_source(
'databricks_cli.version', os.path.join('databricks_cli', 'version.py')).version
path_to_module = os.path.join('databricks_cli', 'version.py')
loaded_module = SourceFileLoader('databricks_cli.version', path_to_module).load_module()
version = loaded_module.version

setup(
name='databricks-cli',
Expand Down
Loading