Skip to content

Commit

Permalink
Remove use of cancel by job id in integration test (#632)
Browse files Browse the repository at this point in the history
## Changes
JobId was recently made optional for the cancel API. This means
`CancelAllRunsByJobId` will no longer exist once we bump the SDK.

This PR removes usage of this method from our integration tests and
examples to unblock SDK generation.

## Tests
Existing tests

- [x] `make test` passing
- [x] `make fmt` applied
- [x] relevant integration tests applied
  • Loading branch information
shreyas-goenka authored Sep 27, 2023
1 parent a77197b commit 02993df
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
4 changes: 3 additions & 1 deletion internal/jobs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ func TestAccJobsApiFullIntegration(t *testing.T) {
})
require.NoError(t, err)

err = w.Jobs.CancelAllRunsByJobId(ctx, createdJob.JobId)
err = w.Jobs.CancelAllRuns(ctx, jobs.CancelAllRuns{
JobId: createdJob.JobId,
})
require.NoError(t, err)

runNowResponse, err := w.Jobs.RunNow(ctx, jobs.RunNow{
Expand Down
2 changes: 1 addition & 1 deletion service/iam/model.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion service/jobs/jobs_usage_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions service/ml/model_registry_usage_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion service/sql/model.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 02993df

Please sign in to comment.