Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE] .databrickscfg loader ignores characters after # in passwords #594

Closed
pietern opened this issue Aug 31, 2023 · 0 comments · Fixed by #595
Closed

[ISSUE] .databrickscfg loader ignores characters after # in passwords #594

pietern opened this issue Aug 31, 2023 · 0 comments · Fixed by #595

Comments

@pietern
Copy link
Contributor

pietern commented Aug 31, 2023

We should investigate whether or not this can be fixed. If it can't be fixed in the loader, we should show an error message.

See databricks/cli#717.
This was referenced Aug 31, 2023
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 31, 2023
@pietern
Fix loading of databrickscfg with a password containing a hash (#595)
eae2e22 
## Changes

Pass options to the ini loader to indicate that inline comments require
a leading whitespace. Any existing configuration that uses inline
comments _without_ a leading whitespace will be interpreted differently
with this change.

Closes #594.

## Tests

- [x] `make test` passing
- [ ] `make fmt` applied
- [ ] relevant integration tests applied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix loading of databrickscfg with a password containing a hash databricks/databricks-sdk-go
1 participant
@pietern