Let google-credentials take precedence over google-id
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that both `GoogleCredentials` and `GoogleServiceAccount` are set. Because `GoogleCredentials` is self-contained, it should have priority over `google-id`.
Codecov ReportBase: 40.73% // Head: 40.73% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
=======================================
Coverage 40.73% 40.73%
=======================================
Files 45 45
Lines 2627 2627
=======================================
Hits 1070 1070
Misses 1475 1475
Partials 82 82
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nfx
reviewed
Jan 18, 2023
nfx
approved these changes
Jan 18, 2023
Merged
nfx
added a commit
that referenced
this pull request
Feb 3, 2023
# Version changelog ## 0.3.0 * Added support for GCP deployment APIs in Public Preview. * Added new node type selector ([#287](#287)). * Added Azure MSI auth ([#279](#279)). * Added validation of strings in user agent package ([#291](#291)). * Added logging for error responses ([#289](#289)). * Update implementation of smallest node selection to match terraform's ([#273](#273)). * Added experimental OAuth support ([#276](#276), [#266](#266), [#292](#292)). * Fixed `google-credentials` to take precedence over `google-id` ([#283](#283)). * Test with Go 1.20 ([#295](#295)). * Regenerate from OpenAPI ([#293](#293), [#294](#294), [#296](#296), [#282](#282), [#269](#269), [#272](#272)). * Added `replaceAll` and `lowerFirst` template functions ([#288](#288), [#277](#277)). Dependency updates: * Bump google.golang.org/api from 0.105.0 to 0.109.0 ([#271](#271), [#280](#280), [#284](#284), [#290](#290)). API changes: * Renamed `clusters.CreateCluster` to `clusters.BaseClusterInfo`. * Renamed `jobs.Job` to `jobs.BaseJob`. * Renamed `jobs.Run` to `jobs.BaseRun`. * Fixed `commands.Results` `Schema` type from `[][]any` to `[]map[string]any`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that both
GoogleCredentialsandGoogleServiceAccountare set. BecauseGoogleCredentialsis self-contained, it should have priority overgoogle-id. This mirrors behavior of the TF provider.