Don't load ~/.databrickscfg if azure-cli auth is implicitly configured
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for presence of `host` isn't enough as it should happen only on Azure, so checking with `IsAzure` works better.
alexott
changed the title
~/.databrickscfg if azure-cli auth is implicitly configured
nfx
approved these changes
Mar 8, 2023
nfx
added a commit
that referenced
this pull request
Mar 8, 2023
* Added `id` field to the `NodeTypeRequest` for easier integration with Terraform's [databricks_node_type](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/node_type) data source ([#325](#325)). * Don't load `~/.databrickscfg` if `azure-cli` auth is implicitly configured ([#324](#324)). * Fixed newline in codegen comments ([#326](#326)). * Update from OpenAPI ([#320](#320), [#328](#328)). API changes: * Renamed `deployment.AwsCredentials` to `deployment.CreateCredentialAwsCredentials`. * Renamed `deployment.StsRole` to `deployment.CreateCredentialStsRole`. * Removed schedules support from `sql.AlertsAPI`. Dependency updates: * Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 ([#318](#318)). * Bump golang.org/x/mod from 0.6.0-dev.0.20220419223038-86c51ed26bb4 to 0.8.0 ([#316](#316)). * Bump golang.org/x/mod from 0.8.0 to 0.9.0 ([#323](#323)). * Bump golang.org/x/oauth2 from 0.5.0 to 0.6.0 ([#322](#322)). * Bump golang.org/x/time from 0.0.0-20210723032227-1f47c861a9ac to 0.3.0 ([#317](#317)). * Bump google.golang.org/api from 0.110.0 to 0.111.0 ([#319](#319)).
Merged
nfx
added a commit
that referenced
this pull request
Mar 8, 2023
* Added `id` field to the `NodeTypeRequest` for easier integration with Terraform's [databricks_node_type](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/node_type) data source ([#325](#325)). * Don't load `~/.databrickscfg` if `azure-cli` auth is implicitly configured ([#324](#324)). * Fixed newline in codegen comments ([#326](#326)). * Update from OpenAPI ([#320](#320), [#328](#328)). API changes: * Renamed `deployment.AwsCredentials` to `deployment.CreateCredentialAwsCredentials`. * Renamed `deployment.StsRole` to `deployment.CreateCredentialStsRole`. * Removed schedules support from `sql.AlertsAPI`. Dependency updates: * Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 ([#318](#318)). * Bump golang.org/x/mod from 0.6.0-dev.0.20220419223038-86c51ed26bb4 to 0.8.0 ([#316](#316)). * Bump golang.org/x/mod from 0.8.0 to 0.9.0 ([#323](#323)). * Bump golang.org/x/oauth2 from 0.5.0 to 0.6.0 ([#322](#322)). * Bump golang.org/x/time from 0.0.0-20210723032227-1f47c861a9ac to 0.3.0 ([#317](#317)). * Bump google.golang.org/api from 0.110.0 to 0.111.0 ([#319](#319)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for presence of
hostisn't enough as it should happen only on Azure, so checking withIsAzureworks better.