Add type to represent a loaded configuration file #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 41.30% 41.30% -0.01%
==========================================
Files 49 49
Lines 2709 2736 +27
==========================================
+ Hits 1119 1130 +11
- Misses 1499 1515 +16
Partials 91 91
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
pietern
commented
Mar 29, 2023
| // The function expands ~ to the user's home directory. | ||
| func LoadFile(path string) (*File, error) { | ||
| if path == "" { | ||
| path = "~/.databrickscfg" |
There was a problem hiding this comment.
Comment from @shreyas-goenka on another thread:
This not work for windows, can be added as a followup though
The permutation test shows that it does work, but I agree it looks weird.
Follow up: use filepath.Join here and check for prefix with os.PathSeparator.
nfx
approved these changes
Mar 31, 2023
|
Integration tests all pass. |
Merged
nfx
added a commit
that referenced
this pull request
Apr 3, 2023
# Version changelog ## 0.6.0 * Added type to represent a loaded configuration file ([#349](#349)). * Added named `Wait` the level of services ([#348](#348)). * Pass `azure_client_id` to Azure MSI if specified ([#354](#354)). Dependency updates: * Bump google.golang.org/api from 0.112.0 to 0.114.0 ([#344](#344)).
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Export type for a loaded configuration file such that downstream applications can read its contents in the same way the SDK does. Rename the loader instance to
ConfigFileto make it symmetric withConfigAttributes.Tests
This doesn't change functionality.
make testpassingmake fmtapplied